Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hcalnano autonano #44492

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Hcalnano autonano #44492

merged 4 commits into from
Mar 28, 2024

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Mar 20, 2024

PR description:

harmonise how hcal DPG nano are configured and tested (#43961)

FYI: @DryRun

PR validation:

nano matrix succeded

a backport "might" be included in #44428

@vlimant
Copy link
Contributor Author

vlimant commented Mar 20, 2024

enable nano

@vlimant
Copy link
Contributor Author

vlimant commented Mar 20, 2024

type hcal

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vlimant for master.

It involves the following packages:

  • Configuration/Applications (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • DPGAnalysis/HcalNanoAOD (xpog)
  • PhysicsTools/NanoAOD (xpog)

@davidlange6, @hqucms, @miquork, @cmsbuild, @AdrianoDee, @vlimant, @fabiocos, @rappoccio, @sunilUIET, @srimanob, @subirsarkar, @antoniovilela can you please review it and eventually sign? Thanks.
@slomeo, @fabiocos, @makortel, @missirol, @Martin-Grunewald, @gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor Author

vlimant commented Mar 20, 2024

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f56e22/38294/summary.html
COMMIT: d704931
CMSSW: CMSSW_14_1_X_2024-03-20-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44492/38294/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 2500.52500.5_ScoutingNanodata13X/step2_ScoutingNanodata13X.log

RelVals-NANO

  • 2500.52500.5_ScoutingNanodata13X/step2_ScoutingNanodata13X.log
  • 2500.512500.51_ScoutingNanomc13X/step1_ScoutingNanomc13X.log

Comparison Summary

Summary:

@vlimant
Copy link
Contributor Author

vlimant commented Mar 21, 2024

+1

@vlimant
Copy link
Contributor Author

vlimant commented Mar 27, 2024

can we please have the remaining signatures, or comments for this trivial PR ? @cms-sw/operations-l2 @cms-sw/pdmv-l2 @cms-sw/upgrade-l2.
Is there a better way to bring such trivial changes forward in quicker way before some conflicts emerge @cms-sw/orp-l2

Comment on lines +160 to +162
'-n' : '100',},
steps['NANO_data13.0']])

Copy link
Contributor

@AdrianoDee AdrianoDee Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this, while unrelated with this PR, is just that you took the chance to implement the merge + steps['NANO_data13.0'] syntax also for @MUDPG auto NANO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry indeed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries of course

@AdrianoDee
Copy link
Contributor

+pdmv

@antoniovilela
Copy link
Contributor

ping @cms-sw/upgrade-l2
Thanks.

@antoniovilela
Copy link
Contributor

can we please have the remaining signatures, or comments for this trivial PR ? @cms-sw/operations-l2 @cms-sw/pdmv-l2 @cms-sw/upgrade-l2. Is there a better way to bring such trivial changes forward in quicker way before some conflicts emerge @cms-sw/orp-l2

Please bring PRs that are taking time to get all signatures during the weekly ORP meeting, where we can also discuss the requested backports.
We had indeed questions concerning backports in the meeting yesterday.
Thanks.

@vlimant
Copy link
Contributor Author

vlimant commented Mar 27, 2024

I am away this week, I'll try to connect to the ORP next week if time permits

@srimanob
Copy link
Contributor

+Upgrade

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 968faf8 into cms-sw:master Mar 28, 2024
13 checks passed
@vlimant vlimant deleted the hcalnano_autonano branch April 2, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants